GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-28411: Fix redundant declaration of _PyImport_AddModuleObject (GH-7992) by miss-islington · Pull Request #8017 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 29, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit f874bd1)

Co-authored-by: Jeremy Cline [email protected]

https://bugs.python.org/issue28411

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jeremycline @miss-islington
Fix redundant declaration of _PyImport_AddModuleObject (pythonGH-7992)
52291ee 
(cherry picked from commit f874bd1)

Co-authored-by: Jeremy Cline <[email protected]>
@the-knights-who-say-ni

the-knights-who-say-ni commented Jun 29, 2018

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA not signed label Jun 29, 2018
@bedevere-bot bedevere-bot added the skip news label Jun 29, 2018
@bedevere-bot bedevere-bot mentioned this pull request Jun 29, 2018
bpo-28411: Fix redundant declaration of _PyImport_AddModuleObject #7992
Merged
@bedevere-bot bedevere-bot added the awaiting review label Jun 29, 2018
@ericsnowcurrently ericsnowcurrently changed the title [3.7] Fix redundant declaration of _PyImport_AddModuleObject (GH-7992) [3.7] bpo-28411: Fix redundant declaration of _PyImport_AddModuleObject (GH-7992) Jun 29, 2018
@bedevere-bot bedevere-bot added the skip news label Jun 29, 2018
ericsnowcurrently
ericsnowcurrently approved these changes Jun 29, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 29, 2018
@miss-islington

miss-islington commented Jun 29, 2018

Copy link
Copy Markdown
Contributor Author

@jeremycline and @ericsnowcurrently: Backport status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit c919252 into python:3.7 Jun 29, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 29, 2018
@miss-islington
miss-islington deleted the backport-f874bd1-3.7 branch June 29, 2018 23:03
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
[subinterpreters] Eliminate PyInterpreterState.modules. #72597
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @the-knights-who-say-ni @ericsnowcurrently @bedevere-bot @jeremycline
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.