GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34255: Ensure that test.test_embed works when blddir != srcdir by ronaldoussoren · Pull Request #8528 · python/cpython

Conversation

@ronaldoussoren

@ronaldoussoren ronaldoussoren commented Jul 28, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The title says it all: this patch uses a different way to locate the _testembed helper for test.test_embed to ensure that this tool can be found when building outside of the source directory.

https://bugs.python.org/issue34255

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ronaldoussoren
bpo-34255: Ensure that test.test_embed works when blddir != srcdir
bb41497 
This changes the way the _testembed command is located to ensure this
helper is found when building outside of the source tree.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jul 28, 2018
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting merge labels Jul 28, 2018
@ronaldoussoren ronaldoussoren added the needs backport to 3.7 label Jul 28, 2018
@serhiy-storchaka
serhiy-storchaka self-requested a review July 29, 2018 04:17
@ronaldoussoren

ronaldoussoren commented Oct 19, 2020

Copy link
Copy Markdown
Contributor Author

There's a conflict and I'm not sure if the PR is still needed. Therefore closing the PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ronaldoussoren ronaldoussoren closed this Oct 19, 2020
@ronaldoussoren ronaldoussoren mentioned this pull request Jun 18, 2022
test_embed skipped when srcdir != builddir #78436
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ronaldoussoren @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.