GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-8110: Refactor platform detection in subprocess by zware · Pull Request #9053 · python/cpython

Conversation

@zware

@zware zware commented Sep 4, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Check for functionality via imports rather than checking sys.platform
specifically for Windows

https://bugs.python.org/issue8110

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zware
bpo-8110: Refactor platform detection in subprocess
bffb9a4 
Check for functionality via imports rather than checking sys.platform
specifically for Windows
@zware
zware requested a review from gpshead as a code owner September 4, 2018 05:02
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 4, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Sep 4, 2018
vstinner
vstinner approved these changes Sep 4, 2018
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pppery
pppery reviewed Sep 8, 2018
View reviewed changes
Comment thread Lib/subprocess.py
try:
import msvcrt
import _winapi
_mswindows = True

@pppery pppery Sep 8, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in the "else" block?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@gpshead gpshead Sep 10, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _mswindows = True? sure, it could be. But it doesn't matter.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
gpshead
gpshead approved these changes Sep 10, 2018
View reviewed changes
@zware
zware merged commit 880d42a into python:master Sep 10, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 10, 2018
@zware
zware deleted the issue8110 branch September 10, 2018 23:16
@zware zware mentioned this pull request Jan 17, 2022
bpo-40280: Change subprocess imports for cleaner error on wasm32 (GH-30620) #30620
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@vstinner vstinner vstinner approved these changes
+1 more reviewer
@pppery pppery pppery left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@zware @gpshead @vstinner @pppery @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.