GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91487: Optimize asyncio UDP speed by msoxzw · Pull Request #91488 · python/cpython

Conversation

@msoxzw

@msoxzw msoxzw commented Apr 12, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix #91487

When transferring a small file, e.g. 256 KiB, the speed of this PR is comparable. However, if a large file, e.g. 65536 KiB, is transferred, asyncio UDP will be over 100 times faster than the original. The speed is presumably significantly faster if a larger file is transferred, e.g. 1048576 KiB.

Automerge-Triggered-By: GH:gpshead

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
illia-v and xingdongzhe reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
msoxzw added 2 commits April 12, 2022 22:55
@msoxzw
Optimize asyncio UDP speed for proactor events
bd37f2f
@msoxzw
Optimize asyncio UDP speed for selector events
1fe6180
@msoxzw
msoxzw requested review from 1st1 and asvetlov as code owners April 12, 2022 23:30
@ghost

ghost commented Apr 12, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Apr 12, 2022
@AlexWaygood AlexWaygood added performance Performance or resource usage topic-asyncio labels Apr 12, 2022
@gpshead

gpshead commented Apr 14, 2022

Copy link
Copy Markdown
Member

Can you add a NEWS entry with blurb or blurb-it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead self-assigned this Apr 14, 2022
@blurb-it
📜🤖 Added by blurb_it.
985739d
gpshead
gpshead approved these changes Apr 15, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 15, 2022
@gpshead gpshead added the 🤖 automerge label Apr 15, 2022
@miss-islington

miss-islington commented Apr 15, 2022

Copy link
Copy Markdown
Contributor

@msoxzw: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 42fabc3 into python:main Apr 15, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 15, 2022
@msoxzw
msoxzw deleted the patch-1 branch April 15, 2022 20:09
@msoxzw msoxzw mentioned this pull request Apr 20, 2022
client-server connection speed is very slow! aiortc/aioquic#258
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

performance Performance or resource usage topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The speed of asyncio UDP is too slow when transferring large file

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@msoxzw @gpshead @miss-islington @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.