GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91731: Build Python with -std=c11 by vstinner · Pull Request #91733 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 20, 2022

Copy link
Copy Markdown
Member

Python is now built with "-std=c11" compiler option, rather than
"-std=c99".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added the awaiting core review label Apr 20, 2022
@vstinner vstinner mentioned this pull request Apr 20, 2022
gh-91731: Replace Py_BUILD_ASSERT() with static_assert() #91730
Merged
@vstinner

vstinner commented Apr 20, 2022

Copy link
Copy Markdown
Member Author

cc @encukou @erlend-aasland
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10
corona10 approved these changes Apr 20, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 20, 2022
@corona10

corona10 commented Apr 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@vstinner You should re-generate configure file or hard-coding change :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
gh-91731: Build Python with -std=c11
1466ea7 
Python is now built with "-std=c11" compiler option, rather than
"-std=c99".
@vstinner

vstinner commented Apr 20, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@vstinner You should re-generate configure file or hard-coding change :)

Oops, right. Done: I ran make regen-configure.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 20, 2022

Copy link
Copy Markdown
Member Author

I checks build logs of macOS and Ubuntu jobs: -std=c11 option is used to build Python core and to build C extensions built as shared libraries.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit aaeea78 into python:main Apr 20, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 20, 2022
@vstinner
vstinner deleted the std_c11 branch April 20, 2022 11:19
@erlend-aasland

erlend-aasland commented Apr 20, 2022

Copy link
Copy Markdown
Contributor

Looks good
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 20, 2022

Copy link
Copy Markdown
Member Author

Thanks for the reviews @corona10 and @erlend-aasland.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Apr 20, 2022
Build Python with C11 #91731
Closed
@h-vetinari h-vetinari mentioned this pull request Oct 25, 2022
3.11.0 conda-forge/python-feedstock#577
Merged
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corona10 corona10 corona10 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @corona10 @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.