GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91760: Deprecate group names and numbers which will be invalid in future by serhiy-storchaka · Pull Request #91794 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 21, 2022

Copy link
Copy Markdown
Member

Only sequence of ASCII digits not starting with 0 (except group 0) will be
accepted as a numerical reference.
The group name in bytes patterns and replacement strings could only
contain ASCII letters and digits and underscore.

Closes #91760.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-91760: Deprecate group names and numbers which will be inval…
a0093c0 
…id in future

Only sequence of ASCII digits not starting with 0 (except group 0) will be
accepted as a numerical reference.
The group name in bytes patterns and replacement strings could only
contain ASCII letters and digits and underscore.
@bedevere-bot bedevere-bot added the awaiting core review label Apr 21, 2022
serhiy-storchaka added 5 commits April 23, 2022 13:00
@serhiy-storchaka
Merge branch 'main' into re-group-name-deprecate
a38e371
@serhiy-storchaka
Minimize diff.
bb7272b
@serhiy-storchaka
Simplify tests.
9965ab2
@serhiy-storchaka
Merge branch 'main' into re-group-name-deprecate
6a594ed
@serhiy-storchaka
Remove restriction for group numerical reference starting with 0.
543d995
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 24, 2022
gh-91760: More strict rules for numerical group references and group names in RE #91792
Merged
serhiy-storchaka
serhiy-storchaka commented Apr 25, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added 2 commits April 25, 2022 13:31
@serhiy-storchaka
Update Doc/whatsnew/3.11.rst
7b95731
@serhiy-storchaka
Merge branch 'main' into re-group-name-deprecate
3b63543
@serhiy-storchaka
serhiy-storchaka merged commit 19dca04 into python:main Apr 30, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 30, 2022
@serhiy-storchaka
serhiy-storchaka deleted the re-group-name-deprecate branch April 30, 2022 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

More strict rules for group numbers and names in RE

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.