GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-80527: Deprecate PEP 623 Unicode functions by vstinner · Pull Request #91801 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 21, 2022

Copy link
Copy Markdown
Member

Deprecate functions:

  • PyUnicode_AS_DATA()
  • PyUnicode_AS_UNICODE()
  • PyUnicode_GET_DATA_SIZE()
  • PyUnicode_GET_SIZE()

Previously, these functions were macros and so it wasn't possible to
decorate them with Py_DEPRECATED().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-80527: Deprecate PEP 623 Unicode functions
afc2c05 
Deprecate functions:

* PyUnicode_AS_DATA()
* PyUnicode_AS_UNICODE()
* PyUnicode_GET_DATA_SIZE()
* PyUnicode_GET_SIZE()

Previously, these functions were macros and so it wasn't possible to
decorate them with Py_DEPRECATED().
@bedevere-bot bedevere-bot added the awaiting core review label Apr 21, 2022
@vstinner

vstinner commented Apr 21, 2022

Copy link
Copy Markdown
Member Author

@methane @serhiy-storchaka: Would one of you review this change? Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Apr 21, 2022

Copy link
Copy Markdown
Member Author

I converted these macros to functions in commit 636ad7b.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Fix typo
da1302e
@methane

methane commented Apr 22, 2022

Copy link
Copy Markdown
Member

Previously, these functions were macros and so it wasn't possible to
decorate them with Py_DEPRECATED().

FWIW, use of these macros caused deprecation warning because wstr and wstr_length are deprecated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane
methane approved these changes Apr 22, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Apr 22, 2022
@vstinner

vstinner commented Apr 22, 2022

Copy link
Copy Markdown
Member Author

FWIW, use of these macros caused deprecation warning because wstr and wstr_length are deprecated.

Oh ok, nice!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 9e146bb into python:main Apr 22, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 22, 2022
@vstinner
vstinner deleted the unicode_deprecate branch April 22, 2022 11:05
@vstinner

vstinner commented Apr 22, 2022

Copy link
Copy Markdown
Member Author

Well, I prefer to make it extra explicit that these functions will be removed soon (Python 3.12) ;-) I'm impatient, I would like to see wstr being removed as soon as possible, I hate the PyUnicode_READY() function!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Apr 26, 2022
[C API] PEP 670: Convert macros to functions in the Python C API #89653
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @methane @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.