GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90667: fix incompatible pointer type warnings by erlend-aasland · Pull Request #91822 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
pythongh-90667: fix incompatible pointer type warnings
485427b
@bedevere-bot bedevere-bot added the awaiting review label Apr 22, 2022
@erlend-aasland
erlend-aasland requested a review from sweeneyde April 22, 2022 12:48
@erlend-aasland erlend-aasland added the skip news label Apr 22, 2022
@erlend-aasland

erlend-aasland commented Apr 22, 2022

Copy link
Copy Markdown
Contributor Author

Alternatively, we can fix the callers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sweeneyde

sweeneyde commented Apr 22, 2022

Copy link
Copy Markdown
Member

Out of curiosity, what does the compiler warning say?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Apr 22, 2022

Copy link
Copy Markdown
Contributor Author

Out of curiosity, what does the compiler warning say?

It's the GitHub CI that complains about incompatible pointer type -Wincompatible-pointer-types.

Screenshot

bilde
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sweeneyde
sweeneyde approved these changes Apr 24, 2022
View reviewed changes

@sweeneyde sweeneyde left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine, I'm just confused why I'm not seeing the compiler warnings anywhere on other PRs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 24, 2022
@erlend-aasland

erlend-aasland commented Apr 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

The change looks fine, I'm just confused why I'm not seeing the compiler warnings anywhere on other PRs.

I accidentally noticed it in GH-30872. I haven't checked other PRs yet, but I suspect it will only appear on PRs that either touch longobject.c or ceval.c. I'll have a look, FWIW.

UPDATE: I'm also seeing them in Victor's PR #91730. However, they are absent in Guido's recent ceval.c PRs. Not sure why, though.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sweeneyde

sweeneyde commented Apr 24, 2022

Copy link
Copy Markdown
Member

Could it be that some of these have been fixed by #91711?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Apr 24, 2022

Copy link
Copy Markdown
Contributor Author

Could it be that some of these have been fixed by #91711?

Ah, that passed me by; sorry for the noise. I'll close this, then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland closed this Apr 24, 2022
@erlend-aasland
erlend-aasland deleted the fix-decref-warnings branch April 24, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sweeneyde sweeneyde sweeneyde approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @sweeneyde @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.