GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-91401: Conservative backport of `subprocess._USE_VFORK` by gpshead · Pull Request #91932 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Apr 26, 2022

Copy link
Copy Markdown
Member

This does not alter the _posixsubprocess.fork_exec() private API to
avoid issues for anyone relying on that (bad idea) or for anyone who's
subprocess.py and _posixsubprocess.so upgrades may not become
visible to existing Python 3.10 processes at the same time.

Backports the concept of cd5726f.

Provides a fail-safe way to disable vfork for #91401.

I didn't backport the documentation as I don't actually expect this to be used and versionadded 3.10.5 always looks weird in docs. It's being done more to have a fail-safe in place for people just in case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
[3.10] Conservative backport of subprocess._USE_VFORK
97933df 
This does not alter the `_posixsubprocess.fork_exec()` private API to
avoid issues for anyone relying on that (bad idea) or for anyone who's
`subprocess.py` and `_posixsubprocess.so` upgrades may not become
visible to existing Python 3.10 processes at the same time.

Backports the concept of cd5726f.
@gpshead gpshead added type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement stdlib Standard Library Python modules in the Lib/ directory extension-modules C modules in the Modules dir labels Apr 26, 2022
@gpshead
gpshead requested a review from pablogsal April 26, 2022 00:16
@bedevere-bot bedevere-bot added the awaiting core review label Apr 26, 2022
gpshead added 5 commits April 26, 2022 00:17
@gpshead
undo addition of a blank line (clean diff)
7e086a6
@gpshead
remove an unnecessary test assert.
6eae10d 
Other tests obviously have this case covered.
@gpshead
Reduce the diff size further.
88a01e1 
Moves the allow_vfork checks into a stanza before the existing setsig stuff.
Avoids reindenting existing code.
@gpshead
better idiom, don't initialize to a default.
ddb8c23
@gpshead
consistency in NULL check idioms.
37192dc
izbyshev
izbyshev reviewed May 1, 2022
View reviewed changes
Comment thread Modules/_posixsubprocess.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
izbyshev
izbyshev approved these changes May 1, 2022
View reviewed changes
gpshead added 2 commits May 1, 2022 15:09
@gpshead
reword the news entry.
35601ba
@gpshead
Merge branch '3.10' into vfork-monsters-3.10
7d75d95
@gpshead
gpshead merged commit ea1eba0 into python:3.10 May 1, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label May 1, 2022
@gpshead
gpshead deleted the vfork-monsters-3.10 branch May 1, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal
1 more reviewer
@izbyshev izbyshev izbyshev approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

extension-modules C modules in the Modules dir stdlib Standard Library Python modules in the Lib/ directory type-bug An unexpected behavior, bug, or error type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@gpshead @izbyshev @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.