GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92193: Check for overridden vectorcall field on PyFunctionObject by itamaro · Pull Request #92194 · python/cpython

Conversation

@itamaro

@itamaro itamaro commented May 2, 2022

Copy link
Copy Markdown
Contributor

gh-92193: Check for overridden vectorcall field on PyFunctionObject

avoid specializing functions with overridden vectorcall field

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@itamaro
Check for overridden vectorcall field on PyFunctionObject
bd98645
@bedevere-bot bedevere-bot added the awaiting review label May 2, 2022
@ambv
ambv requested a review from markshannon May 2, 2022 21:38
@markshannon

markshannon commented May 2, 2022

Copy link
Copy Markdown
Member

I'm not sure that this makes sense by itself, as we never check vectorcall if version is non-zero.
If we add PyFunction_SetVectorCall() that sets version to zero, when it sets vectorcall, then this would work.
itamaro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@itamaro

itamaro commented May 2, 2022

Copy link
Copy Markdown
Contributor Author

I'm not sure that this makes sense by itself, as we never check vectorcall if version is non-zero.

makes sense. we can do that, and/or move the vectorcall check to before the version check (and then maybe it does make sense by itself?). what do you think @markshannon ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@itamaro

itamaro commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

this PR is made obsolete by GH-92257
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@itamaro itamaro closed this May 3, 2022
@itamaro
itamaro deleted the check-modified-vectorcall branch March 22, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@itamaro @markshannon @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.