GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91321: Fix PyModuleDef_HEAD_INIT on C++ by vstinner · Pull Request #92259 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 3, 2022

Copy link
Copy Markdown
Member

The PyModuleDef_HEAD_INIT macro now uses _Py_NULL to fix C++ compiler
warnings when using it in C++.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-91321: Fix PyModuleDef_HEAD_INIT on C++
bf4dc94 
The PyModuleDef_HEAD_INIT macro now uses _Py_NULL to fix C++ compiler
warnings when using it in C++.
@vstinner vstinner added the skip news label May 3, 2022
@bedevere-bot bedevere-bot added the awaiting core review label May 3, 2022
@vstinner

vstinner commented May 3, 2022

Copy link
Copy Markdown
Member Author

test_cppext failed on:

  • AMD64 Debian PGO 3.x: https://buildbot.python.org/all/#/builders/249/builds/2595
  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash 3.x: https://buildbot.python.org/all/#/builders/469/builds/2554
  • aarch64 RHEL8 3.x: https://buildbot.python.org/all/#/builders/529/builds/2034
  • s390x SLES 3.x: https://buildbot.python.org/all/#/builders/540/builds/2694
  • PPC64LE RHEL8 3.x: https://buildbot.python.org/all/#/builders/559/builds/1798
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 3a35b62 into python:main May 3, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label May 3, 2022
@vstinner
vstinner deleted the moduledef branch May 3, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.