GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.7] bpo-40548: Fix "Check for source changes (pull_request)" GH Action job (GH-21806) by miss-islington · Pull Request #92342 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor

On Git 2.28, "git diff master..." (3 dots) no longer works when
"fetch --depth=1" is used, whereas it works on Git 2.26.

Replace "..." (3 dots) with ".." (2 dots) in the "git diff" command
computing the list of modified files between the base branch and the
PR branch.
(cherry picked from commit eaa5517)

Co-authored-by: Victor Stinner [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
bpo-40548: Fix "Check for source changes (pull_request)" GH Action job (
5097cd4 
pythonGH-21806)

On Git 2.28, "git diff master..." (3 dots) no longer works when
"fetch --depth=1" is used, whereas it works on Git 2.26.

Replace "..." (3 dots) with ".." (2 dots) in the "git diff" command
computing the list of modified files between the base branch and the
PR branch.
(cherry picked from commit eaa5517)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the skip news label May 5, 2022
@bedevere-bot bedevere-bot mentioned this pull request May 5, 2022
bpo-40548: Fix "Check for source changes (pull_request)" GH Action job #21806
Merged
@bedevere-bot bedevere-bot added the awaiting review label May 5, 2022
JelleZijlstra
JelleZijlstra approved these changes May 5, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 5, 2022
@JelleZijlstra JelleZijlstra mentioned this pull request May 5, 2022
[3.7] gh-80254: Disallow recursive usage of cursors in sqlite3 converters #92334
Merged
@vstinner

vstinner commented May 5, 2022

Copy link
Copy Markdown
Member

Why do you need this backport today?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented May 5, 2022

Copy link
Copy Markdown
Member

See #92334
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ned-deily added 2 commits May 6, 2022 12:10
@ned-deily
Merge branch '3.7' into backport-eaa5517-3.7
30f512f
@ned-deily
Merge branch '3.7' into backport-eaa5517-3.7
f258668
@erlend-aasland

erlend-aasland commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

Do we still want to pursue this in the 3.7 branch?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ned-deily
Resolve merge conflict
a49e8b7
@ned-deily
ned-deily merged commit 9d58933 into python:3.7 Sep 2, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 2, 2022
@miss-islington
miss-islington deleted the backport-eaa5517-3.7 branch September 2, 2022 03:28
@ned-deily

ned-deily commented Sep 2, 2022

Copy link
Copy Markdown
Member

Do we still want to pursue this in the 3.7 branch?

Sorry, this should have been merged earlier; it slipped off my radar. Thanks for the backport!
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @vstinner @JelleZijlstra @erlend-aasland @ned-deily @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.