GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92332: Docs-only deprecation of `typing.Text` by AlexWaygood · Pull Request #92351 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented May 5, 2022

Copy link
Copy Markdown
Member

Closes #92332

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
Docs-only deprecation of typing.Text
ec5bb2c
@AlexWaygood
AlexWaygood requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners May 5, 2022 21:51
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 5, 2022
@AlexWaygood AlexWaygood added the topic-typing label May 5, 2022
hauntsaninja
hauntsaninja reviewed May 6, 2022
View reviewed changes
Comment thread Doc/library/typing.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood and others added 4 commits May 6, 2022 08:03
@AlexWaygood @hauntsaninja
Update Doc/library/typing.rst
5d5a855 
Co-authored-by: Shantanu <[email protected]>
@AlexWaygood
Minor rewording
72b6f2a
@AlexWaygood
Merge remote-tracking branch 'origin/main' into typing-dot-text
e1ffa80
@AlexWaygood
Whatsnew
0edfa9e
Fidget-Spinner
Fidget-Spinner approved these changes May 6, 2022
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 6, 2022
@Fidget-Spinner

Fidget-Spinner commented May 6, 2022

Copy link
Copy Markdown
Member

I'm going to merge this first in case we inadvertently miss the beta freeze cutoff. We can just fix up anything else in the docs if Jelle spots problems later.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
Fidget-Spinner merged commit 6f18b86 into python:main May 6, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 6, 2022
@AlexWaygood
AlexWaygood deleted the typing-dot-text branch May 6, 2022 10:17
@AlexWaygood

AlexWaygood commented May 6, 2022

Copy link
Copy Markdown
Member Author

I'm going to merge this first in case we inadvertently miss the beta freeze cutoff. We can just fix up anything else in the docs if Jelle spots problems later.

Thanks @Fidget-Spinner 😊
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra reviewed May 6, 2022
View reviewed changes
Comment thread Doc/library/typing.rst
.. deprecated:: 3.11
Python 2 is no longer supported, and most type checkers also no longer
support type checking Python 2 code. Users should now use
:class:`str` instead of ``Text`` wherever possible.

@JelleZijlstra JelleZijlstra May 6, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add an explicit note here saying that removal is not currently planned? A "deprecated" note can make users think it will be removed soon.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AlexWaygood AlexWaygood May 6, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(For future readers of this PR):

  • typing.Text: tweak deprecation notice #92405

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments
@hauntsaninja hauntsaninja hauntsaninja left review comments
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate typing.Text

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AlexWaygood @Fidget-Spinner @JelleZijlstra @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.