GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92584: test_cppext uses setuptools by vstinner · Pull Request #92639 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 10, 2022

Copy link
Copy Markdown
Member

Rewrite test_cppext to run in a virtual environment and to build the
C++ extension with setuptools rather than distutils.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-92584: test_cppext uses setuptools
df0fa1f 
Rewrite test_cppext to run in a virtual environment and to build the
C++ extension with setuptools rather than distutils.
@vstinner vstinner added the skip news label May 10, 2022
@bedevere-bot bedevere-bot added the awaiting core review label May 10, 2022
@vstinner vstinner mentioned this pull request May 10, 2022
PEP 632: Remove the distutils package (Python 3.12) #92584
Closed
@vstinner

vstinner commented May 10, 2022

Copy link
Copy Markdown
Member Author

If this approach works and is accepted, we can use the same for test_peg_generator.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@FFY00

FFY00 commented May 11, 2022

Copy link
Copy Markdown
Member

What happens if CPython for some reason breaks setuptools?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 11, 2022

Copy link
Copy Markdown
Member Author

What happens if CPython for some reason breaks setuptools?

The test fails which is a good thing :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 4e28377 into python:main May 12, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label May 12, 2022
@vstinner
vstinner deleted the test_cppext_setuptools branch May 12, 2022 22:20
@vstinner

vstinner commented May 12, 2022

Copy link
Copy Markdown
Member Author

Let's try and see how it goes :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AbhigyanBose AbhigyanBose mentioned this pull request May 15, 2022
test_cppext fails on Ubuntu 20.04 when _ctypes fails to build #92820
Closed
@vstinner

vstinner commented May 16, 2022

Copy link
Copy Markdown
Member Author

Let's try and see how it goes :-)

It fails when _ctypes is not available: #92820

@FFY00: An example of failing setuptools :-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pradyunsg pradyunsg mentioned this pull request Jan 14, 2023
gh-95299: Stop installing setuptools as a part of ensurepip and venv #101039
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @FFY00 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.