GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92584: test_decimal uses shutil.which() by vstinner · Pull Request #92640 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 10, 2022

Copy link
Copy Markdown
Member

test_decimal now uses shutil.which() rather than deprecated
distutils.spawn.find_executable().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-92584: test_decimal uses shutil.which()
f29def8 
test_decimal now uses shutil.which() rather than deprecated
distutils.spawn.find_executable().
@vstinner vstinner added the skip news label May 10, 2022
@vstinner
vstinner requested a review from rhettinger as a code owner May 10, 2022 20:52
@bedevere-bot bedevere-bot added the awaiting core review label May 10, 2022
@vstinner vstinner mentioned this pull request May 10, 2022
PEP 632: Remove the distutils package (Python 3.12) #92584
Closed
serhiy-storchaka
serhiy-storchaka approved these changes May 10, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 10, 2022
@vstinner

vstinner commented May 10, 2022

Copy link
Copy Markdown
Member Author

Tests / Windows (x64) (pull_request) In progress — This check has started...

test_concurrent_futures is stuck and Python didn't respect the timeout :-(

Run tests in parallel using 4 child processes (timeout: 20 min, worker timeout: 25 min)
(...)
2:06:08 load avg: 0.00 running: test_concurrent_futures (1 hour 52 min)

I cancelled the job and then scheduled a new one (re-run).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit dfdebda into python:main May 10, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 10, 2022
@vstinner
vstinner deleted the decimal_which branch May 10, 2022 23:42
@vstinner

vstinner commented May 10, 2022

Copy link
Copy Markdown
Member Author

Merged. Thanks for the review @serhiy-storchaka.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.