GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-91810: ElementTree: Use text file's encoding by default in XML declaration (GH-91903) by miss-islington · Pull Request #92664 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

ElementTree method write() and function tostring() now use the text file's
encoding ("UTF-8" if not available) instead of locale encoding in XML
declaration when encoding="unicode" is specified.
(cherry picked from commit 707839b)

Co-authored-by: Serhiy Storchaka [email protected]

Automerge-Triggered-By: GH:serhiy-storchaka

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @miss-islington
pythongh-91810: ElementTree: Use text file's encoding by default in X…
d44991b 
…ML declaration (pythonGH-91903)

ElementTree method write() and function tostring() now use the text file's
encoding ("UTF-8" if not available) instead of locale encoding in XML
declaration when encoding="unicode" is specified.
(cherry picked from commit 707839b)

Co-authored-by: Serhiy Storchaka <[email protected]>
@miss-islington

miss-islington commented May 11, 2022

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request May 11, 2022
gh-91810: ElementTree: Use text file's encoding by default in XML declaration #91903
Merged
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label May 11, 2022
@miss-islington

miss-islington commented May 11, 2022

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label May 11, 2022
@serhiy-storchaka serhiy-storchaka added the 🤖 automerge label May 11, 2022
@miss-islington

miss-islington commented May 11, 2022

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka added the awaiting merge label May 11, 2022
@miss-islington

miss-islington commented May 11, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka removed the awaiting review label May 11, 2022
@kumaraditya303 kumaraditya303 added awaiting merge and removed awaiting merge labels May 11, 2022
@miss-islington
miss-islington merged commit 4730b0d into python:3.10 May 11, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 11, 2022
@miss-islington
miss-islington deleted the backport-707839b-3.10 branch May 11, 2022 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @serhiy-storchaka @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.