GeezerVison is showing github.com — Change `__future__` docs description to avoid confusion with concurrency futures by arhadthedev · Pull Request #92760 · python/cpython
Conversation
arhadthedev
commented
May 13, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Currently, the library index page describes __future__ as:
__future__ — Future statement definitions
However, it creates confusion with futures from the concurrency domain. So this PR changes the description to:
__future__ — Early access to language features created for future versions of Python
Edit: replaced with a shorter wording:
__future__ — Early access to future language features
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an improvement to me.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Could anybody merge the PR if possible please? This is the last one after gh-92761 and gh-92762.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I don't find the current wording unclear, and the proposed new wording is so long that it will make the page title spill into multiple lines on many screens. If another core dev has a different opinion, I won't object to merging this though.
|
arhadthedev reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
arhadthedev
commented
Jul 24, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
@JelleZijlstra Will Early access to future language features be better?
Edit: for comparison:
original: Future statement definitions
initial: Early access to language features for future versions of Python
fixed: Early access to future language features
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Applied the shorter wording described above.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
arhadthedev
changed the title
Dissociate __future__ docs description from concurrency futures
Change __future__ docs description to avoid confusion with concurrency futures
Aug 25, 2022
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sorry, I still don't see a reason for change here. I'm leaving this open in case another core dev thinks there's room for improvement, but I'm not planning to merge anything.
|
arhadthedev reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
carljm
carljm approved these changes
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|