GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Change `__future__` docs description to avoid confusion with concurrency futures by arhadthedev · Pull Request #92760 · python/cpython

Conversation

@arhadthedev

@arhadthedev arhadthedev commented May 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Currently, the library index page describes __future__ as:

__future__ — Future statement definitions

However, it creates confusion with futures from the concurrency domain. So this PR changes the description to:

__future__ — Early access to language features created for future versions of Python

Edit: replaced with a shorter wording:

__future__ — Early access to future language features

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@arhadthedev
Dissociate __future__ doc description from concurrency futures
11f952d
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 13, 2022
@AlexWaygood AlexWaygood added skip issue skip news labels May 16, 2022
carljm
carljm reviewed May 17, 2022
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/library/__future__.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/__future__.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

arhadthedev and others added 2 commits May 17, 2022 20:21
@arhadthedev @carljm
Update Doc/library/__future__.rst
73a89c1
Co-authored-by: Carl Meyer <[email protected]>
@arhadthedev
Update the synopsis as well
81c3058
carljm
carljm approved these changes May 17, 2022
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 17, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 needs backport to 3.11 only security fixes labels May 22, 2022
arhadthedev added 2 commits June 22, 2022 23:52
@arhadthedev
Merge branch 'main' into doc-__future__
999ecc7
@arhadthedev
Merge branch 'main' into doc-__future__
993b63a
@arhadthedev

arhadthedev commented Jul 18, 2022

Copy link
Copy Markdown
Member Author

Could anybody merge the PR if possible please? This is the last one after gh-92761 and gh-92762.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@kumaraditya303
kumaraditya303 requested a review from JelleZijlstra July 22, 2022 16:25
@JelleZijlstra

JelleZijlstra commented Jul 23, 2022

Copy link
Copy Markdown
Member

I don't find the current wording unclear, and the proposed new wording is so long that it will make the page title spill into multiple lines on many screens. If another core dev has a different opinion, I won't object to merging this though.

arhadthedev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra
JelleZijlstra removed their request for review July 23, 2022 00:28
@arhadthedev

arhadthedev commented Jul 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@JelleZijlstra Will Early access to future language features be better?

Edit: for comparison:

original:  Future statement definitions
initial:   Early access to language features for future versions of Python
fixed:     Early access to future language features
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev
Shorten the wording
bc30fc9
@arhadthedev

arhadthedev commented Jul 30, 2022

Copy link
Copy Markdown
Member Author

Applied the shorter wording described above.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev arhadthedev changed the title Dissociate __future__ docs description from concurrency futures Change __future__ docs description to avoid confusion with concurrency futures Aug 25, 2022
arhadthedev added 2 commits August 25, 2022 13:28
@arhadthedev
Merge branch 'main' into doc-__future__
9221bd7
@arhadthedev
Merge branch 'main' into doc-__future__
1527af0
@arhadthedev

arhadthedev commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

Ping.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra

JelleZijlstra commented Oct 6, 2022

Copy link
Copy Markdown
Member

Sorry, I still don't see a reason for change here. I'm leaving this open in case another core dev thinks there's room for improvement, but I'm not planning to merge anything.

arhadthedev reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@arhadthedev arhadthedev closed this Oct 15, 2022
@arhadthedev
arhadthedev deleted the doc-__future__ branch October 15, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir needs backport to 3.11 only security fixes skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@arhadthedev @JelleZijlstra @carljm @bedevere-bot @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.