GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92536: Compute unicode struct sizes to ensure MemError is raised by sweeneyde · Pull Request #92867 · python/cpython

Conversation

@sweeneyde

@sweeneyde sweeneyde commented May 17, 2022

Copy link
Copy Markdown
Member

I believe this is the cause of recent failing x86 Gentoo buildbots.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sweeneyde
Update unicode struct size to ensure MemError is raised
111ece3
@sweeneyde sweeneyde added the skip news label May 17, 2022
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels May 17, 2022
@sweeneyde
sweeneyde requested a review from methane May 17, 2022 04:09
@sweeneyde sweeneyde added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 17, 2022
@bedevere-bot

bedevere-bot commented May 17, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @sweeneyde for commit 111ece3 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 17, 2022
@sweeneyde

sweeneyde commented May 17, 2022

Copy link
Copy Markdown
Member Author

Gentoo bots are green for the first time in a little while.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
methane
methane approved these changes May 17, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 17, 2022
@sweeneyde
sweeneyde merged commit 19a4252 into python:main May 17, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 17, 2022
@sweeneyde
sweeneyde deleted the unicode_memerror branch May 17, 2022 14:12
@ambv

ambv commented May 17, 2022

Copy link
Copy Markdown
Contributor

Could this be backported to 3.11 and 3.10?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sweeneyde

sweeneyde commented May 17, 2022

Copy link
Copy Markdown
Member Author

Sure, it could, but it's not changing anything there other than clarity. The main reason it matters is that Unicode struct size changed in 3.12 due to PEP 623.
ambv reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv

ambv commented May 17, 2022

Copy link
Copy Markdown
Contributor

OK, nevermind then.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane methane approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sweeneyde @bedevere-bot @ambv @methane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.