GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93183: Adjust wording in socket docs by VictorNorman · Pull Request #92935 · python/cpython

Conversation

@VictorNorman

@VictorNorman VictorNorman commented May 18, 2022

Copy link
Copy Markdown

Replace "package" and "packages" with "packet" and "packets" in comments in sample code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@VictorNorman
Update socket.rst
de7954c
Replace "package" and "packages" with "packet" and "packets" in comments in sample code.
@ghost

ghost commented May 18, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

Click the button to sign:
CLA not signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented May 18, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 18, 2022
@AlexWaygood AlexWaygood added the skip news label May 18, 2022
@rhettinger rhettinger assigned tiran May 19, 2022
@erlend-aasland erlend-aasland changed the title Update socket.rst Doc: adjust wording in socket docs May 19, 2022
@erlend-aasland erlend-aasland added the skip issue label May 19, 2022
@erlend-aasland erlend-aasland assigned erlend-aasland and unassigned tiran May 19, 2022
@erlend-aasland
Merge branch 'main' into patch-1
0b4099e
@erlend-aasland

erlend-aasland commented May 19, 2022

Copy link
Copy Markdown
Contributor

@VictorNorman, please sign the CLA.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti
ezio-melotti approved these changes May 20, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 20, 2022
erlend-aasland
erlend-aasland approved these changes May 20, 2022
View reviewed changes
@erlend-aasland

erlend-aasland commented May 20, 2022

Copy link
Copy Markdown
Contributor

@VictorNorman, please sign the CLA.

Quoting https://devguide.python.org/committing/#assessing-a-pull-request:

Make sure that the contributor has signed a Contributor Licensing Agreement (CLA), unless their change has no possible intellectual property associated with it (e.g. fixing a spelling mistake in documentation)

AFAICS, this PR can land without the CLA being signed.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented May 20, 2022

Copy link
Copy Markdown
Contributor

Quoting https://devguide.python.org/committing/#assessing-a-pull-request:

Make sure that the contributor has signed a Contributor Licensing Agreement (CLA), unless their change has no possible intellectual property associated with it (e.g. fixing a spelling mistake in documentation)

AFAICS, this PR can land without the CLA being signed.

Darn, that does not help; I'm unable to merge since the CI does not pass. So, @VictorNorman, please sign the CLA, or I cannot merge this.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label May 20, 2022
erlend-aasland added 2 commits May 20, 2022 18:14
@erlend-aasland
Merge branch 'main' into patch-1
c1ce140
@erlend-aasland
Merge branch 'main' into patch-1
e44d6cd
@erlend-aasland erlend-aasland linked an issue May 24, 2022 that may be closed by this pull request
[docs] socket documentation: "packages" -> "packets" #93183
Closed
@erlend-aasland erlend-aasland changed the title Doc: adjust wording in socket docs gh-93183: Adjust wording in socket docs May 24, 2022
@erlend-aasland erlend-aasland removed the skip issue label May 24, 2022
@AA-Turner

AA-Turner commented May 26, 2022

Copy link
Copy Markdown
Member

I'm unable to merge since the CI does not pass

This seems to be a regression with the new CLA system - was it intended? @VictorNorman has an institutional email address, so may need to go through the corporate signing process with his university, rather than the individual process.

A

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner AA-Turner added needs backport to 3.10 needs backport to 3.11 only security fixes labels May 26, 2022
@erlend-aasland

erlend-aasland commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

I'm not sure what to do with this PR. Should we just close it? As long as Victor Norman does not respond, there is not much I can do, at least.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@AA-Turner

AA-Turner commented Jun 14, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@erlend-aasland it isn't a copyrightable change, so I would close and you could just push the changes & backport as a core dev (I would open a PR myself but I'm plagued by CLA issues!)

A

erlend-aasland, ezio-melotti, and AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland

erlend-aasland commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

Ok, thanks, I'll do that tomorrow.

AA-Turner and ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@erlend-aasland erlend-aasland closed this Jun 15, 2022
@AA-Turner AA-Turner removed the pending The issue will be closed if no feedback is provided label Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@ezio-melotti ezio-melotti ezio-melotti approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@erlend-aasland erlend-aasland

Labels

awaiting merge docs Documentation in the Doc dir needs backport to 3.11 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[docs] socket documentation: "packages" -> "packets"

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@VictorNorman @bedevere-bot @erlend-aasland @AA-Turner @ezio-melotti @tiran @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.