GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-33073: Fix-up parenthesis, organization, and NULL check by rhettinger · Pull Request #9297 · python/cpython

Conversation

@rhettinger

@rhettinger rhettinger commented Sep 14, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Follow-up to unseen comments on PR 8750

https://bugs.python.org/issue33073

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rhettinger
Fix-up parenthesis, organization, and NULL check
4c0714b
@rhettinger rhettinger added the skip news label Sep 14, 2018
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 14, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Sep 14, 2018
@eric-wieser eric-wieser mentioned this pull request Sep 14, 2018
bpo-33073: Adding as_integer_ratio to ints. #8750
Merged
eric-wieser
eric-wieser approved these changes Sep 14, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting merge labels Sep 14, 2018
@eric-wieser

eric-wieser commented Sep 14, 2018

Copy link
Copy Markdown
Contributor

Hmm, that's an interesting behavior of @bedevere-bot...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Sep 14, 2018
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 14, 2018
@rhettinger rhettinger self-assigned this Sep 14, 2018
@rhettinger
rhettinger merged commit 00bc08e into python:master Sep 14, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
+1 more reviewer
@eric-wieser eric-wieser eric-wieser approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@rhettinger rhettinger

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@rhettinger @eric-wieser @pablogsal @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.