GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-93115: Fix version check in sqlite3 module constants test (GH-93116) by miss-islington · Pull Request #93128 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 23, 2022

Copy link
Copy Markdown
Contributor

(cherry picked from commit d5f0dd1)

Co-authored-by: Florian Bruhin [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@The-Compiler @miss-islington
pythonGH-93115: Fix version check in sqlite3 module constants test (p…
e5f7ea2 
…ythonGH-93116)

(cherry picked from commit d5f0dd1)

Co-authored-by: Florian Bruhin <[email protected]>
@miss-islington
miss-islington requested review from berkerpeksag and erlend-aasland as code owners May 23, 2022 15:59
@bedevere-bot bedevere-bot mentioned this pull request May 23, 2022
GH-93115: Fix error code tests in test_sqlite3.test_dbapi #93116
Merged
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir awaiting review labels May 23, 2022
@miss-islington

miss-islington commented May 23, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes May 23, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 23, 2022
@erlend-aasland erlend-aasland mentioned this pull request May 23, 2022
test_sqlite3.test_dbapi: Extended error codes aren't actually tested #93115
Closed
@miss-islington

miss-islington commented May 23, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit acc998a into python:3.11 May 23, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 23, 2022
@miss-islington
miss-islington deleted the backport-d5f0dd1-3.11 branch May 23, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @erlend-aasland @bedevere-bot @The-Compiler
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.