GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Comment nit: fix comment reference in pycore_interp.h by itamaro · Pull Request #93188 · python/cpython

Conversation

@itamaro

@itamaro itamaro commented May 24, 2022

Copy link
Copy Markdown
Contributor

GH-31527 moved this typedef to Include/pytypedefs.h, so this comment should point at the correct location

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@itamaro
Comment nit: fix comment reference in pycore_interp.h
249a207 
pythonGH-31527 moved this typedef to `Include/pytypedefs.h`, so this comment should point at the correct location
@bedevere-bot bedevere-bot added the awaiting review label May 24, 2022
@hauntsaninja hauntsaninja added skip issue skip news labels Jul 8, 2022
hauntsaninja
hauntsaninja approved these changes Jul 8, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jul 8, 2022
@kumaraditya303 kumaraditya303 assigned vstinner Jul 8, 2022
@vstinner
vstinner merged commit 0fc8ac0 into python:main Jul 9, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 9, 2022
@vstinner

vstinner commented Jul 9, 2022

Copy link
Copy Markdown
Member

Merged, thanks.
itamaro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@itamaro @vstinner @hauntsaninja @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.