GeezerVison is showing github.com — gh-92886: Fix test in `test_routines.py` so that it works when running with optimizations (`-O`) by jackh-ncl · Pull Request #93232 · python/cpython
Conversation
jackh-ncl
commented
May 25, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
#92886
Before:
$ ./python.exe -Om unittest test.test_coroutines
........................./Users/.../dev/cpython/Lib/test/test_coroutines.py:2207: RuntimeWarning: coroutine 'CoroutineTest.test_bpo_45813_2.<locals>.f' was never awaited
with self.assertWarns(RuntimeWarning):
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
............................................................F.........
======================================================================
FAIL: test_with_5 (test.test_coroutines.CoroutineTest.test_with_5)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/Users/.../dev/cpython/Lib/test/test_coroutines.py", line 1284, in test_with_5
with self.assertRaises(AssertionError):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: AssertionError not raised
----------------------------------------------------------------------
Ran 95 tests in 0.323s
FAILED (failures=1)
After:
$ ./python.exe -Om unittest test.test_coroutines
........................./Users/jackhindmarch/dev/cpython/Lib/test/test_coroutines.py:2207: RuntimeWarning: coroutine 'CoroutineTest.test_bpo_45813_2.<locals>.f' was never awaited
with self.assertWarns(RuntimeWarning):
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
......................................................................
----------------------------------------------------------------------
Ran 95 tests in 0.325s
OK
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
News entry is not required, you can remove it.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
News entry is not required, you can remove it.
done
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Sorry, I didn't see this.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.