GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-71566: Fix SocketType introduction in the socket documentation. by xiaochen7 · Pull Request #93288 · python/cpython

Conversation

@xiaochen7

@xiaochen7 xiaochen7 commented May 27, 2022 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In the previous commit, SocketType was changed to the base class for the socket object type.

The purpose of this PR is to align the documentation with the above modifications.

  • Issue: [doc] SocketType changed in Python 3 #71566

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xiaochen7
pythongh-71566: Fix SocketType introduction in the socket documentation.
7d9e9d7
@ghost

ghost commented May 27, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 27, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 27, 2022
@blurb-it
📜🤖 Added by blurb_it.
f7d3261
@xiaochen7 xiaochen7 mentioned this pull request May 27, 2022
[doc] SocketType changed in Python 3 #71566
Closed
@AA-Turner

AA-Turner commented May 27, 2022

Copy link
Copy Markdown
Member

You don't need NEWS, please delete it.

A
xiaochen7 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner added needs backport to 3.10 needs backport to 3.11 only security fixes labels May 27, 2022
AA-Turner
AA-Turner requested changes May 27, 2022
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two wording suggestions.

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/socket.rst Outdated
Comment on lines +829 to +830
This is the base class for a type object of socket objects, and
``isinstance(socket(...), SocketType)`` returns ``True``.

@AA-Turner AA-Turner May 27, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is the base class for a type object of socket objects, and
``isinstance(socket(...), SocketType)`` returns ``True``.
This is the base class for socket objects, such that
``isinstance(socket(...), SocketType)`` is ``True``.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@xiaochen7 xiaochen7 May 28, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your professional advice. As we can see, socket.SocketType is the base class for the type object socket.socket. Consider that elsewhere in this document socket object refers to an instance of the type object socket.socket. Wouldn't it be less precise if we just said that SocketType is the base class of socket objects? Looking forward to your more suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/socket.rst Outdated
``isinstance(socket(...), SocketType)`` returns ``True``.

.. versionchanged:: 3.0
SocketType is now the base class for the socket object type.

@AA-Turner AA-Turner May 27, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SocketType is now the base class for the socket object type.
SocketType is the base class for socket objects
rather than being ``type(socket(...))``` directly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 27, 2022
@AA-Turner AA-Turner added the skip news label May 27, 2022
xiaochen7 added 2 commits May 28, 2022 16:33
@xiaochen7
delete NEWS
bfda8d7
@xiaochen7
apply wording suggestions from Adam Turner
491e69e
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes and removed needs backport to 3.10 needs backport to 3.11 only security fixes labels May 9, 2024
@willingc
Merge branch 'main' into pythongh-71566
08842e1
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 10, 2025
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025
@StanFromIreland
Merge branch 'main' into pythongh-71566
a9dc39b
@StanFromIreland StanFromIreland mentioned this pull request Dec 29, 2025
gh-71566: Fix SocketType documentation in socket.rst #143272
Closed
aisk
aisk reviewed Dec 30, 2025
View reviewed changes
Comment thread Doc/library/socket.rst

.. versionchanged:: 3.0
SocketType is the base class for the socket object type rather than
being ``type(socket(...))``` directly.

@aisk aisk Dec 30, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a RST marker error:

Suggested change
being ``type(socket(...))``` directly.
being ``type(socket(...))`` directly.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@github-actions

github-actions Bot commented Apr 11, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 11, 2026
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.15 bugs and security fixes label May 30, 2026
@gaborbernat gaborbernat mentioned this pull request May 31, 2026
gh-89554: Document socket.SocketType as a class #150683
Merged
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jun 5, 2026
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 6, 2026
@aisk

aisk commented Sep 6, 2026

Copy link
Copy Markdown
Member

Already fixed in #150683
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aisk aisk closed this Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk left review comments
@AA-Turner AA-Turner AA-Turner requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review docs Documentation in the Doc dir needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes skip news stale Stale PR or inactive for long period of time.

Projects

Docs PRs
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@xiaochen7 @bedevere-bot @AA-Turner @aisk @hugovk @serhiy-storchaka @willingc @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.