GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-34699: allow path-like objects in program arguments in Windows by guoci · Pull Request #9336 · python/cpython

Conversation

@guoci

@guoci guoci commented Sep 15, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Currently, the subprocess.Popen function allows for path-like objects in the argument list for POSIX but not in Windows.
This PR makes Windows' subprocess.Popen accept path-like objects in the argument list.

https://bugs.python.org/issue34699

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@guoci
guoci requested a review from gpshead as a code owner September 15, 2018 19:24
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 15, 2018
@bedevere-bot bedevere-bot added the awaiting review label Sep 15, 2018
@guoci
guoci force-pushed the pathlike_in_windows_args branch from 1f7f706 to 70d5aeb Compare September 15, 2018 19:33
@guoci guoci changed the title bpo-34699: allows path-like objects in program arguments in Windows bpo-34699: allow path-like objects in program arguments in Windows Sep 15, 2018
@guoci
guoci force-pushed the pathlike_in_windows_args branch 5 times, most recently from ab921a3 to c73eed0 Compare October 22, 2018 22:01
@guoci
guoci force-pushed the pathlike_in_windows_args branch 5 times, most recently from 41fff51 to 61e7743 Compare October 31, 2018 15:01
@guoci
guoci force-pushed the pathlike_in_windows_args branch from 61e7743 to f8fe934 Compare November 5, 2018 21:26
@guoci
allows path-like objects in program arguments in Windows
84e5946
@guoci
guoci force-pushed the pathlike_in_windows_args branch from f8fe934 to 84e5946 Compare November 8, 2018 21:43
@serhiy-storchaka

serhiy-storchaka commented Nov 9, 2018

Copy link
Copy Markdown
Member

Superseded by #5914.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka serhiy-storchaka closed this Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@guoci @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.