GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-92886: Fix test that fails when running with `-O` in `test_imaplib.py` (GH-93237) by miss-islington · Pull Request #93485 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 4, 2022

Copy link
Copy Markdown
Contributor

(cherry picked from commit 8150b8c)

Co-authored-by: jackh-ncl [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jackh-ncl @miss-islington
pythongh-92886: Fix test that fails when running with -O in `test_i…
d7e85cc 
…maplib.py` (pythonGH-93237)

(cherry picked from commit 8150b8c)

Co-authored-by: jackh-ncl <[email protected]>
@miss-islington
miss-islington requested a review from a team as a code owner June 4, 2022 03:16
@bedevere-bot bedevere-bot mentioned this pull request Jun 4, 2022
gh-92886: Fixing test that fails when running with optimizations (-O) in test_imaplib.py #93237
Merged
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jun 4, 2022
JelleZijlstra
JelleZijlstra approved these changes Jun 4, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 4, 2022
@miss-islington

miss-islington commented Jun 4, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: 3 of 6 required status checks are expected..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra self-assigned this Jun 4, 2022
@miss-islington

miss-islington commented Jun 4, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 7b3cf3a into python:3.10 Jun 4, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 4, 2022
@miss-islington
miss-islington deleted the backport-8150b8c-3.10 branch June 4, 2022 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @JelleZijlstra @bedevere-bot @jackh-ncl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.