GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91404: Revert "bpo-23689: re module, fix memory leak when a match is terminated by a signal or memory allocation failure (GH-32283)" · Pull Request #93559 · python/cpython

Conversation

@ghost

@ghost ghost commented Jun 7, 2022

Copy link
Copy Markdown

In nesting repeats, a repeat context may have multiple active existences at the same time.
So 6e3eee5's method is wrong.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wjssz
Revert "bpo-23689: re module, fix memory leak when a match is termina…
54714b5 
…ted by a signal or memory allocation failure (GH-32283)"

This reverts commit 6e3eee5.
@bedevere-bot bedevere-bot added the awaiting review label Jun 7, 2022
@wjssz
NEWS
6aae4d8
@corona10 corona10 added the needs backport to 3.11 only security fixes label Jun 7, 2022
@corona10
corona10 requested a review from serhiy-storchaka June 7, 2022 05:44
@sweeneyde sweeneyde added the topic-regex label Jun 8, 2022
@Hello71 Hello71 mentioned this pull request Jun 15, 2022
gh-91404: Revert "bpo-23689: re module, fix memory leak when a match is terminated by a signal or allocation failure (GH-32283) #93882
Merged
@gpshead
gpshead requested a review from pablogsal June 15, 2022 23:53
@gpshead

gpshead commented Jun 15, 2022

Copy link
Copy Markdown
Member

I created a similar PR as I hadn't seen this one mentioned on the #91404 issue.

At a quick glance without diving deep to compare diffs, the MAGIC constants are not being updated by this PR while I decided to do that in mine.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost ghost closed this Jun 16, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka
@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review needs backport to 3.11 only security fixes topic-regex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@gpshead @corona10 @bedevere-bot @sweeneyde @wjssz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.