GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-90494: Reject 6th element of the __reduce__() tuple (GH-93609) by miss-islington · Pull Request #93632 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

copy.copy() and copy.deepcopy() now always raise a TypeError if
reduce() returns a tuple with length 6 instead of silently ignore
the 6th item or produce incorrect result.
(cherry picked from commit a365dd6)

Co-authored-by: Serhiy Storchaka [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka @miss-islington
pythongh-90494: Reject 6th element of the __reduce__() tuple (pythonG…
fb2256e 
…H-93609)

copy.copy() and copy.deepcopy() now always raise a TypeError if
__reduce__() returns a tuple with length 6 instead of silently ignore
the 6th item or produce incorrect result.
(cherry picked from commit a365dd6)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Jun 9, 2022
gh-90494: Reject 6th element of the __reduce__() tuple #93609
Merged
@miss-islington

miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Jun 9, 2022
@miss-islington

miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Riahiamirreza
Riahiamirreza reviewed Jun 9, 2022
View reviewed changes
Comment thread Lib/copy.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit a0c7df0 into python:3.10 Jun 10, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Jun 10, 2022
@miss-islington
miss-islington deleted the backport-a365dd6-3.10 branch June 10, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@TeamSpen210 TeamSpen210 TeamSpen210 left review comments
@Riahiamirreza Riahiamirreza Riahiamirreza left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @TeamSpen210 @Riahiamirreza @ambv @bedevere-bot @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.