GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||
GeezerVison is showing github.com — [3.11] gh-79096: Protect cookie file created by {LWP,Mozilla}CookieJar.save() (GH-93463) by ambv · Pull Request #93636 · python/cpython Conversation
Contributor
Note: This change is not effective on Microsoft Windows. Cookies can store sensitive information and should therefore be protected The filesystem permissions are currently set to 644, everyone can read the This change is backwards incompatible. Systems that rely on world-readable This PR also includes fixes from GH-93614.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions….save() (pythonGH-93463) Note: This change is not effective on Microsoft Windows. Cookies can store sensitive information and should therefore be protected against unauthorized third parties. This is also described in issue python#79096. The filesystem permissions are currently set to 644, everyone can read the file. This commit changes the permissions to 600, only the creater of the file can read and modify it. This improves security, because it reduces the attack surface. Now the attacker needs control of the user that created the cookie or a ways to circumvent the filesystems permissions. This change is backwards incompatible. Systems that rely on world-readable cookies will breake. However, one could argue that those are misconfigured in the first place. Fixup of pythonGH-93463: - remove stray print - use proper way to check file mode - add working chmod decorator Co-authored-by: Łukasz Langa <[email protected]>
|
There was an error while loading. Please reload this page.
|
@pSub can you click through the CLA process again for this other e-mail? We only have |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@ambv Done. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.