GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — [3.11] gh-90549: Fix leak of global named resources using multiprocessing spawn (GH-30617) by miss-islington · Pull Request #93651 · python/cpython Conversation
Contributor
Co-authored-by: XD Trol [email protected] Co-authored-by: Leo Trol [email protected]
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions…ing spawn (pythonGH-30617) Co-authored-by: XD Trol <[email protected]> Co-authored-by: Antoine Pitrou <[email protected]> (cherry picked from commit 30610d2) Co-authored-by: Leo Trol <[email protected]>
|
There was an error while loading. Please reload this page.
|
@vstinner Do you know why we get a CLA signing failure here that did not exist on the original PR? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
vs
One email has a dot, not the other. I don't know what's going on. @ambv: Do you have an idea why the email address is different and the CLA check fails? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
CLA fixed. It seems that Github auto-generated commits ignore dots in email addresses, but the CLA bot does not. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
🤖 New build scheduled with the buildbot fleet by @pitrou for commit 54e06c1 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, backport from main branch.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The CLA bot should probably also ignore dots in emails. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@jxdabc I cannot reproduce the dot discrepancy with GitHub. Are you sure you don't have a difference between your local |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
test_signal has been running for 28 min on the remaining buildbot... Is it ok to merge nevertheless? @vstinner |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Status check is done, and it's a success ✅ . |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@pitrou In my experience the buildbots get added in waves so the fact that there is "just one left" isn't enough to merge early. In this case miss-islington already merged so hopefully we went through all of them. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Yes, the email address in ~/.gitconfig does differ from GitHub account email address. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.