GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-90549: Fix leak of global named resources using multiprocessing spawn (GH-30617) by miss-islington · Pull Request #93651 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor

Co-authored-by: XD Trol [email protected]
Co-authored-by: Antoine Pitrou [email protected]
(cherry picked from commit 30610d2)

Co-authored-by: Leo Trol [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@jxdabc @miss-islington
pythongh-90549: Fix leak of global named resources using multiprocess…
54e06c1
…ing spawn (pythonGH-30617)

Co-authored-by: XD Trol <[email protected]>
Co-authored-by: Antoine Pitrou <[email protected]>
(cherry picked from commit 30610d2)

Co-authored-by: Leo Trol <[email protected]>
@miss-islington
miss-islington requested a review from 1st1 as a code owner June 9, 2022 16:55
@ghost

ghost commented Jun 9, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a failure ❌ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot mentioned this pull request Jun 9, 2022
gh-90549: Fix leak of global named resources using multiprocessing spawn #30617
Merged
@miss-islington

miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a failure ❌ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot added the awaiting review label Jun 9, 2022
@pitrou

pitrou commented Jun 9, 2022

Copy link
Copy Markdown
Member

@vstinner Do you know why we get a CLA signing failure here that did not exist on the original PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Jun 9, 2022

Copy link
Copy Markdown
Member

Co-authored-by: XD Trol [email protected]

vs

The following commit authors need to sign the Contributor License Agreement: [email protected]

One email has a dot, not the other. I don't know what's going on.

@ambv: Do you have an idea why the email address is different and the CLA check fails?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Jun 9, 2022

Copy link
Copy Markdown
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a failure ❌ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@jxdabc

jxdabc commented Jun 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Co-authored-by: XD Trol [email protected]

vs

The following commit authors need to sign the Contributor License Agreement: [email protected]

One email has a dot, not the other. I don't know what's going on.

@ambv: Do you have an idea why the email address is different and the CLA check fails?

CLA fixed. It seems that Github auto-generated commits ignore dots in email addresses, but the CLA bot does not.

cc @vstinner @pitrou

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pitrou pitrou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 10, 2022
@bedevere-bot

bedevere-bot commented Jun 10, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @pitrou for commit 54e06c1 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 10, 2022
@miss-islington

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner
vstinner approved these changes Jun 10, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, backport from main branch.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 10, 2022
pitrou
pitrou approved these changes Jun 10, 2022
View reviewed changes
@ambv

ambv commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

The CLA bot should probably also ignore dots in emails.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv

ambv commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

@jxdabc I cannot reproduce the dot discrepancy with GitHub. Are you sure you don't have a difference between your local ~/.gitconfig email address and the GitHub account email address?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

@jxdabc and @pitrou: Status check is done, and it's a pending ❌ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pitrou

pitrou commented Jun 10, 2022

Copy link
Copy Markdown
Member

test_signal has been running for 28 min on the remaining buildbot... Is it ok to merge nevertheless? @vstinner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington
miss-islington merged commit aee7d3d into python:3.11 Jun 10, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 10, 2022
@miss-islington
miss-islington deleted the backport-30610d2-3.11 branch June 10, 2022 15:05
@ambv

ambv commented Jun 10, 2022

Copy link
Copy Markdown
Contributor

@pitrou In my experience the buildbots get added in waves so the fact that there is "just one left" isn't enough to merge early. In this case miss-islington already merged so hopefully we went through all of them.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ambv ambv mentioned this pull request Jun 11, 2022
Should normalized_email be stripped of dots and +parts, too? geldata/cla-bot#51
Closed
@jxdabc

jxdabc commented Jun 14, 2022

Copy link
Copy Markdown
Contributor

@jxdabc I cannot reproduce the dot discrepancy with GitHub. Are you sure you don't have a difference between your local ~/.gitconfig email address and the GitHub account email address?

Yes, the email address in ~/.gitconfig does differ from GitHub account email address.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@pitrou pitrou pitrou approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @pitrou @vstinner @jxdabc @bedevere-bot @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.