The following commit authors need to sign the Contributor License Agreement:

• [email protected]
• [email protected]

Click the button to sign:

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

You will need a NEWS entry, along the lines of Added tests to :mod:`calendar` to achieve full test coverage.

A

@AA-Turner
You will need a NEWS entry, along the lines of Added tests to :mod:`calendar` to achieve full test coverage.

Thanks! I just added it.

Another problem is the lack of CLA signatures from @jesstess and @rohitmediratta. The applied patches were quite old, so I'm not sure the email addresses are up to date (I don't know if the bot is sending emails about the CLA). Anyway, it looks like GitHub has assigned these commits to the correct usernames, so I'm tagging Jessica and Rohit in this comment to help notify :)

You'll need to fix the Ubuntu failures in test_locale_calendar_formatmonthname too:

Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_calendar.py", line 650, in test_locale_calendar_formatmonthname
    self.assertEqual(cal.formatmonthname(2022, 6, 2, withyear=False), "June")
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/calendar.py", line 588, in formatmonthname
    with different_locale(self.locale):
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/calendar.py", line 555, in __enter__
    _locale.setlocale(_locale.LC_TIME, self.locale)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/locale.py", line 626, in setlocale
    return _setlocale(category, locale)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
locale.Error: unsupported locale setting

This may be another test-skipping scenario, I don't know what the values it is trying to set are though so I can't guess much further.

A

I'm tagging Jessica and Rohit in this comment to help notify

You might also want to consider emailing the two of them if you don't hear back, neither seem to have much recent publicly shown activity on GH.

A

@AA-Turner
You'll need to fix the Ubuntu failures in test_locale_calendar_formatmonthname too:

This may be another test-skipping scenario, I don't know what the values it is trying to set are though so I can't guess much further.

Or maybe (based on the traceback) it's related to one of the corner cases from #93655 (comment)?
I don't have access to Ubuntu at the moment but I can revert that change and see what happens before further investigation.
This is a newly added test BTW.

I can revert that change and see what happens before further investigation.

Sadly it doesn't seem to have worked :(

A

Sadly it doesn't seem to have worked :(

Yes, I misread the traceback in a rush before disconnecting, but I wanted to kick off builds to get results when I get back. Time saving ;)

For now, I have restored a96786c.

However, it is true that the cause of the problem is related to #31214 and as you correctly predicted, this is another test-skipping scenario. Fixed in 2b6f1f9.

test_illegal_arguments and test_too_many_arguments fail in Azure Pipelines PR.
I will try to investigate it, but for now I'm marking this PR as a draft.

test_illegal_arguments and test_too_many_arguments fail in Azure Pipelines PR.
I will try to investigate it, but for now I'm marking this PR as a draft.

Fixed in 8b7bc06.

Ok, all comments are now addressed and resolved. All tests pass successfully. ✔️
Still missing CLA signatures from @jesstess and @rohitmediratta. I will email them directly. 🤞

I think the PR is ready for another round of reviews ;-)

Good news for the weekend.

Rohit signed the CLA. Thanks again @rohitmediratta!

I also looked at @jesstess GH profile and I believe the missing CLA has already been signed by Jessica as she is a former director of the Python Software Foundation and a member of @python.

I've emailed [email protected] to sort this out.

Here is the holdup situation:
For https://bugs.python.org/issue13330, Attempt full test coverage of LocaleTextCalendar.formatweekday
Sean Fleming, no CLA recorded, uploaded a patch 2011-11-03 02:14.
bpo user jesstess Jessica McKellar, https://bugs.python.org/user11041, signed the CLA "on: 2013-04-12.20:00:00".
She more or less rejected Sean's patch and uploaded a much different patch,
https://bugs.python.org/file35060/issue13330.patch on 2014-04-27 16:43.
Serhiy Storchaka mentioned a couple of problems.

When moved to gh, issue became #57539. Irit Katriel requested gh PR and mentioned this issue.
Last June, hugovk converted Jessica's patch to a PR, with the correction requested by Serhiy.
The commit message mistakenly said "Co-authored-by: Sean Fleming". This apparently did not trigger the CLA bot of the time to request a signature from Sean. ambv merged and backported on June 7, 2022.

On June 9, bxsx added ab069a4, which added Jessica's original code, without the Serhiy correction. It somehow credited Jessica as author. Fortunately, the deletion of the correction is somehow not in the merged patch. Unfortunately, it fooled the CLA bot into thinking that she was an author of this PR.

@ambv This PR, which has had a lot of work by multiple people, is blocked by the false 'need' for an unobtainable signature from @jesstess Jessica McKeller, who did not contribute to this PR. Should reverting ab069a4 fix the mistake or is something else needed. If so, can you override the bot? (Though a final review may be needed.)