GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-92886: Fix tests that fail when running with optimizations (`-O`) in `test_zipimport.py` (GH-93236) by miss-islington · Pull Request #93704 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 10, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 484a235)

Co-authored-by: jackh-ncl [email protected]

Automerge-Triggered-By: GH:brettcannon

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jackh-ncl @miss-islington
pythongh-92886: Fix tests that fail when running with optimizations (…
9609230 
…`-O`) in `test_zipimport.py` (pythonGH-93236)

(cherry picked from commit 484a235)

Co-authored-by: jackh-ncl <[email protected]>
@miss-islington
miss-islington requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners June 10, 2022 22:57
@miss-islington

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Jun 10, 2022
gh-92886: Fixing tests that fail when running with optimizations (-O) in test_zipimport.py #93236
Merged
@miss-islington

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Jun 10, 2022
@brettcannon brettcannon self-assigned this Jun 10, 2022
brettcannon
brettcannon approved these changes Jun 10, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 10, 2022
@brettcannon brettcannon added the 🤖 automerge label Jun 10, 2022
@miss-islington

miss-islington commented Jun 10, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 0aa9ec9 into python:3.11 Jun 10, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 10, 2022
@miss-islington
miss-islington deleted the backport-484a235-3.11 branch June 10, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brettcannon brettcannon

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @brettcannon @bedevere-bot @jackh-ncl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.