GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.11] gh-79512: Fixed names and __module__ value of weakref classes (GH-93719) by miss-islington · Pull Request #93789 · python/cpython

Conversation

miss-islington commented Jun 14, 2022

Copy link

Copy Markdown

Contributor

Classes ReferenceType, ProxyType and CallableProxyType have now correct
atrtributes module, name and qualname.
It makes them (types, not instances) pickleable.
(cherry picked from commit 8352e32)

Co-authored-by: Serhiy Storchaka [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-79512: Fixed names and __module__ value of weakref classes (p…

b0bf575

…ythonGH-93719)

Classes ReferenceType, ProxyType and CallableProxyType have now correct
atrtributes __module__, __name__ and __qualname__.
It makes them (types, not instances) pickleable.
(cherry picked from commit 8352e32)

Co-authored-by: Serhiy Storchaka <[email protected]>

miss-islington commented Jun 14, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot mentioned this pull request

Jun 14, 2022

gh-79512: Fixed names and __module__ value of weakref classes #93719

Merged

miss-islington commented Jun 14, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment

miss-islington commented Jun 14, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting review label

Jun 14, 2022

miss-islington commented Jun 14, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Jun 14, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Jun 14, 2022

miss-islington merged commit 29c7e81 into python:3.11

Jun 14, 2022

bedevere-bot removed the awaiting merge label

Jun 14, 2022

miss-islington deleted the backport-8352e32-3.11 branch

June 14, 2022 19:13

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.