GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-93662: Make sure that column offsets are correct in multi-line method calls. (GH-93673) by iritkatriel · Pull Request #93895 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jun 16, 2022

Copy link
Copy Markdown
Member

(Manually cherry-picked from commit 2bf7475, and resolved conflict in Python/compile.c, function maybe_optimize_method_call).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon @iritkatriel
pythonGH-93662: Make sure that column offsets are correct in multi-li…
483f3d0 
…ne method calls. (pythonGH-93673)
@iritkatriel
iritkatriel requested a review from pablogsal June 16, 2022 10:01
@iritkatriel
iritkatriel requested a review from markshannon as a code owner June 16, 2022 10:01
@bedevere-bot bedevere-bot mentioned this pull request Jun 16, 2022
GH-93662: Make sure that column offsets are correct in multi-line method calls. #93673
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Jun 16, 2022
@iritkatriel iritkatriel mentioned this pull request Jun 16, 2022
Incorrect line number calculated in traceback #93662
Closed
pablogsal
pablogsal approved these changes Jun 16, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 16, 2022
@pablogsal

pablogsal commented Jun 16, 2022

Copy link
Copy Markdown
Member

Thanks for the backport @iritkatriel 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
pablogsal merged commit df091e1 into python:3.11 Jun 16, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 16, 2022
This was referenced Jul 8, 2022
3.11 branch: column >= -1 assertion failure with pytest rewriting #94694
Open
Support Python 3.11 qutebrowser/qutebrowser#7143
Closed
@iritkatriel
iritkatriel deleted the backport-93673-3.11 branch October 18, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @pablogsal @bedevere-bot @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.