GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.11] gh-91731: Don't define 'static_assert' in C++11 where is a keyword to avoid UB (GH-93700) by miss-islington · Pull Request #93907 · python/cpython

Conversation

miss-islington commented Jun 16, 2022

Copy link

Copy Markdown

Contributor

(cherry picked from commit 65ff27c)

Co-authored-by: Pablo Galindo Salgado [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-91731: Don't define 'static_assert' in C++11 where is a keyw…

491392a

…ord to avoid UB (pythonGH-93700)

(cherry picked from commit 65ff27c)

Co-authored-by: Pablo Galindo Salgado <[email protected]>

miss-islington commented Jun 16, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment

miss-islington commented Jun 16, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot mentioned this pull request

Jun 16, 2022

gh-91731: Don't define 'static_assert' in C++11 where is a keyword to avoid UB #93700

Merged

bedevere-bot added the awaiting review label

Jun 16, 2022

pablogsal approved these changes

Jun 16, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Jun 16, 2022

miss-islington commented Jun 16, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington merged commit 7456109 into python:3.11

Jun 16, 2022

bedevere-bot removed the awaiting merge label

Jun 16, 2022

miss-islington deleted the backport-65ff27c-3.11 branch

June 16, 2022 14:50

Reviewers

pablogsal

pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.