GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] test_logging: Fix BytesWarning in SysLogHandlerTest (GH-93920) by miss-islington · Pull Request #93930 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 17, 2022

Copy link
Copy Markdown
Contributor

(cherry picked from commit 538f289)

Co-authored-by: Victor Stinner [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
test_logging: Fix BytesWarning in SysLogHandlerTest (pythonGH-93920)
0e84477 
(cherry picked from commit 538f289)

Co-authored-by: Victor Stinner <[email protected]>
@miss-islington
miss-islington requested a review from vsajip as a code owner June 17, 2022 09:26
@miss-islington

miss-islington commented Jun 17, 2022

Copy link
Copy Markdown
Contributor Author

@vstinner and @vsajip: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Jun 17, 2022

Copy link
Copy Markdown
Contributor Author

@vstinner and @vsajip: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the skip issue label Jun 17, 2022
@bedevere-bot bedevere-bot mentioned this pull request Jun 17, 2022
test_logging: Fix BytesWarning in SysLogHandlerTest (GH-93920) #93920
Merged
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir awaiting review labels Jun 17, 2022
vstinner
vstinner approved these changes Jun 17, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 17, 2022
vsajip
vsajip approved these changes Jun 17, 2022
View reviewed changes
@miss-islington

miss-islington commented Jun 17, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 5e30ba1 into python:3.10 Jun 17, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 17, 2022
@miss-islington
miss-islington deleted the backport-538f289-3.10 branch June 17, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajip vsajip vsajip approved these changes
@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @vsajip @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.