GeezerVison is showing github.com — [3.11] gh-93975: Nicer error reporting in test_venv (GH-93959) by jaraco · Pull Request #94003 · python/cpython
Conversation
jaraco
commented
Jun 19, 2022
•
edited by miss-islington
Loading
Uh oh!
There was an error while loading. Please reload this page.
This change does three things:
- Extract a function for trapping output in subprocesses.
- Emit both stdout and stderr when encountering an error.
- Apply the change to
ensurepip._uninstall check.
(cherry picked from commit 6066f45)
Co-authored-by: Jason R. Coombs [email protected]
Automerge-Triggered-By: GH:jaraco
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
- gh-93957: Provide nicer error reporting from subprocesses in test_venv.EnsurePipTest.test_with_pip.
- Update changelog
This change does three things:
1. Extract a function for trapping output in subprocesses.
2. Emit both stdout and stderr when encountering an error.
3. Apply the change to `ensurepip._uninstall` check.
(cherry picked from commit 6066f45)
Co-authored-by: Jason R. Coombs <[email protected]>
Reviewers
vsajip
Awaiting requested review from vsajip
vsajip is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Labels
tests
Tests in the Lib/test dir
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.