GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-61162: Clarify sqlite3 connection context manager docs (GH-93890) by miss-islington · Pull Request #94013 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 19, 2022

Copy link
Copy Markdown
Contributor

Explicitly note that transactions are only closed if there is an open
transation at __exit__, and that transactions are not implicitly
opened during __enter__.

Co-authored-by: CAM Gerlach [email protected]
Co-authored-by: Stanley [email protected]

Automerge-Triggered-By: GH:erlend-aasland
(cherry picked from commit 8e08978)

Co-authored-by: Erlend Egeberg Aasland [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland @miss-islington
pythongh-61162: Clarify sqlite3 connection context manager docs (pyth…
fe47619 
…onGH-93890)

Explicitly note that transactions are only closed if there is an open
transation at `__exit__`, and that transactions are not implicitly
opened during `__enter__`.

Co-authored-by: CAM Gerlach <[email protected]>
Co-authored-by: Stanley <[email protected]>

Automerge-Triggered-By: GH:erlend-aasland
(cherry picked from commit 8e08978)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@miss-islington
miss-islington requested review from berkerpeksag and erlend-aasland as code owners June 19, 2022 20:19
@bedevere-bot bedevere-bot added the awaiting review label Jun 19, 2022
@miss-islington

miss-islington commented Jun 19, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Jun 19, 2022
@bedevere-bot bedevere-bot mentioned this pull request Jun 19, 2022
gh-61162: Clarify sqlite3 connection context manager docs #93890
Merged
erlend-aasland
erlend-aasland approved these changes Jun 19, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 19, 2022
@erlend-aasland erlend-aasland mentioned this pull request Jun 19, 2022
The sqlite3 context manager does not work with isolation_level=None #61162
Closed
@miss-islington

miss-islington commented Jun 19, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit b99f398 into python:3.11 Jun 19, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 19, 2022
@miss-islington
miss-islington deleted the backport-8e08978-3.11 branch June 19, 2022 20:28
@miss-islington

miss-islington commented Jun 19, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
erlend-aasland reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.