GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-25711: Remove outdated zipimport tests. by serhiy-storchaka · Pull Request #9404 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 18, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

They were specific to the C implementation.

https://bugs.python.org/issue25711

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-25711: Remove outdated zipimport tests.
810a6e5 
They were specific to the C implementation.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Sep 18, 2018
@serhiy-storchaka
serhiy-storchaka requested a review from a team September 18, 2018 19:56
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 18, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Sep 18, 2018
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 18, 2018
bpo-25711: Rewrite zipimport in pure Python. #6809
Merged
warsaw
warsaw approved these changes Sep 19, 2018
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit b2984ab into python:master Sep 19, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 19, 2018
@serhiy-storchaka
serhiy-storchaka deleted the zipimport-tests-outdated branch September 19, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @warsaw @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.