GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-25711: Move _ZipImportResourceReader from importlib to zipimport. by serhiy-storchaka · Pull Request #9406 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 18, 2018 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue25711

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement skip news labels Sep 18, 2018
@serhiy-storchaka
serhiy-storchaka requested a review from a team September 18, 2018 20:20
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Sep 18, 2018
@bedevere-bot bedevere-bot added the awaiting merge label Sep 18, 2018
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 18, 2018
bpo-25711: Rewrite zipimport in pure Python. #6809
Merged
warsaw
warsaw approved these changes Sep 18, 2018
View reviewed changes

@warsaw warsaw left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see where it's removed from the importlib source, but maybe I'm missing it. Other than that, this looks good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
bpo-25711: Move _ZipImportResourceReader from importlib to zipimport.
c734452
@serhiy-storchaka
serhiy-storchaka force-pushed the zipimport-resource-reader branch from 0164bf0 to c734452 Compare September 18, 2018 21:12
@serhiy-storchaka

serhiy-storchaka commented Sep 18, 2018

Copy link
Copy Markdown
Member Author

Oh, I forgot to save these changes. Thank you for noticing this. Updated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
warsaw
warsaw approved these changes Sep 19, 2018
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit 9da3961 into python:master Sep 19, 2018
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 19, 2018
@serhiy-storchaka
serhiy-storchaka deleted the zipimport-resource-reader branch September 19, 2018 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @warsaw @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.