GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-79512: Fixed names and __module__ value of weakref classes (GH-93719) by serhiy-storchaka · Pull Request #94071 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 21, 2022

Copy link
Copy Markdown
Member

Classes ReferenceType, ProxyType and CallableProxyType have now correct
atrtributes module, name and qualname.
It makes them (types, not instances) pickleable.
(cherry picked from commit 8352e32)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
[3.10] pythongh-79512: Fixed names and __module__ value of weakref cl…
4456b3c 
…asses (pythonGH-93719)

Classes ReferenceType, ProxyType and CallableProxyType have now correct
atrtributes __module__, __name__ and __qualname__.
It makes them (types, not instances) pickleable..
(cherry picked from commit 8352e32)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot bedevere-bot added the awaiting core review label Jun 21, 2022
@bedevere-bot bedevere-bot mentioned this pull request Jun 21, 2022
gh-79512: Fixed names and __module__ value of weakref classes #93719
Merged
@serhiy-storchaka
serhiy-storchaka merged commit 54250e7 into python:3.10 Jun 21, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 21, 2022
@serhiy-storchaka
serhiy-storchaka deleted the backport-8352e32-3.10 branch February 19, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.