GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-91387: Fix tarfile test on WASI (GH-93984) by tiran · Pull Request #94074 · python/cpython

Conversation

@tiran

@tiran tiran commented Jun 21, 2022

Copy link
Copy Markdown
Member

WASI's rmdir() syscall does not like the trailing slash.
(cherry picked from commit dd78aae)

Co-authored-by: Christian Heimes [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
[3.11] pythongh-91387: Fix tarfile test on WASI (pythonGH-93984)
1cf777f 
WASI's rmdir() syscall does not like the trailing slash.
(cherry picked from commit dd78aae)

Co-authored-by: Christian Heimes <[email protected]>
@tiran
tiran requested a review from ethanfurman as a code owner June 21, 2022 18:46
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir skip news labels Jun 21, 2022
@tiran tiran mentioned this pull request Jun 21, 2022
[3.11] gh-91387: Fix tarfile test on WASI (GH-93984) #93993
Closed
ethanfurman
ethanfurman approved these changes Jun 21, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 21, 2022
@tiran
tiran merged commit b1b0656 into python:3.11 Jun 21, 2022
@tiran
tiran deleted the backport-dd78aae-3.11 branch June 21, 2022 19:25
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tiran @ethanfurman @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.