GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-93021: Fix __text_signature__ for __get__ (GH-93023) by miss-islington · Pull Request #94085 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 21, 2022

Copy link
Copy Markdown
Contributor

Because of the way wrap_descr_get is written, the second argument
to get methods implemented through the wrapper is always
optional.
(cherry picked from commit 4e08fbc)

Co-authored-by: Jelle Zijlstra [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra @miss-islington
pythongh-93021: Fix __text_signature__ for __get__ (pythonGH-93023)
706c9e3 
Because of the way wrap_descr_get is written, the second argument
to __get__ methods implemented through the wrapper is always
optional.
(cherry picked from commit 4e08fbc)

Co-authored-by: Jelle Zijlstra <[email protected]>
@miss-islington
miss-islington requested a review from markshannon as a code owner June 21, 2022 19:45
@bedevere-bot bedevere-bot added the awaiting review label Jun 21, 2022
@miss-islington

miss-islington commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Jun 21, 2022
gh-93021: Fix __text_signature__ for __get__ #93023
Merged
@miss-islington

miss-islington commented Jun 21, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit a1565a8 into python:3.11 Jun 21, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Jun 21, 2022
@miss-islington
miss-islington deleted the backport-4e08fbc-3.11 branch June 21, 2022 20:32
@coderabbitai coderabbitai Bot mentioned this pull request Aug 2, 2026
typedef: validate the classmethod_descriptor owner and share wrap_descr_get pyre-lang/pyre#981
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @ambv @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.