GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.10] gh-74696: Do not change the current working directory in shutil.make_archive() if possible (GH-93160) by miss-islington · Pull Request #94106 · python/cpython

Conversation

miss-islington commented Jun 22, 2022

Copy link

Copy Markdown

Contributor

It is no longer changed when create a zip or tar archive.

It is still changed for custom archivers registered with shutil.register_archive_format()
if root_dir is not None.

Co-authored-by: Éric [email protected]
Co-authored-by: Łukasz Langa [email protected]
(cherry picked from commit fda4b2f)

Co-authored-by: Serhiy Storchaka [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-74696: Do not change the current working directory in shutil…

d6823a8

….make_archive() if possible (pythonGH-93160)

It is no longer changed when create a zip or tar archive.

It is still changed for custom archivers registered with shutil.register_archive_format()
if root_dir is not None.

Co-authored-by: Éric <[email protected]>
Co-authored-by: Łukasz Langa <[email protected]>
(cherry picked from commit fda4b2f)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot added the awaiting review label

Jun 22, 2022

miss-islington commented Jun 22, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

2 similar comments

miss-islington commented Jun 22, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Jun 22, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot mentioned this pull request

Jun 22, 2022

gh-74696: Do not change the current working directory in shutil.make_archive() if possible #93160

Merged

miss-islington commented Jun 22, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment

miss-islington commented Jun 22, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ambv merged commit e51a22b into python:3.10

Jun 22, 2022

bedevere-bot removed the awaiting review label

Jun 22, 2022

miss-islington deleted the backport-fda4b2f-3.10 branch

June 22, 2022 09:18

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.