GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add ABI dump to .gitignore by encukou · Pull Request #94166 · python/cpython

Conversation

@encukou

@encukou encukou commented Jun 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The ABI is only checked in maintenance branches, but it is sometimes useful to generate it for main.

  • The resulting file should be ignored in main.
  • The file should be created if it doesn't exist.

If this goes in, some “make maintenance branch” RM checklist/script will need a “remove Doc/data/python*.abi from .gitignore” entry.

@pablogsal, this could be combined with #94135

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Add ABI dump to .gitignore
9a2466d 
The ABI is only checked in maintenance branches, but it is sometimes
useful to generate it for main.

- The resulting file should be ignored in main.
- The file should be created if it doesn't exist.
@encukou encukou added skip issue skip news labels Jun 23, 2022
@encukou
encukou requested a review from pablogsal June 23, 2022 11:35
@bedevere-bot bedevere-bot added the awaiting core review label Jun 23, 2022
@arhadthedev

arhadthedev commented Jun 23, 2022

Copy link
Copy Markdown
Member

remove Doc/data/python*.abi from .gitignore

Calling git add with --force allows to keep gitignore unmodified:

-f, --force
Allow adding otherwise ignored files.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Jun 23, 2022

Copy link
Copy Markdown
Member Author

Yes, but AFAIK there are then warnings when you update a file that's ignored but tracked anyway.
The maintenance branches need some changes anyway – adding the CI check, at least – so I asume it's not a big burden to update .gitignore.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Jun 23, 2022

Copy link
Copy Markdown
Member

@pablogsal, this could be combined with #94135

@encukou do you want me to add this change to that PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Jun 23, 2022

Copy link
Copy Markdown
Member Author

Go ahead!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @arhadthedev @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.