GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-93976: [Enum] Remove automatic docstring generation (GH-94188) by miss-islington · Pull Request #94191 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 23, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 28a2ccf)

Co-authored-by: Sam Ezeh [email protected]

  • Issue: 3.11 creates doctests for Enum subclasses brittle against globs and overridden __repr__ #93976

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dignissimus @miss-islington
[Enum] Remove automatic docstring generation (pythonGH-94188)
6e33025 
(cherry picked from commit 28a2ccf)

Co-authored-by: Sam Ezeh <[email protected]>
@miss-islington
miss-islington requested a review from ethanfurman as a code owner June 23, 2022 20:35
@bedevere-bot bedevere-bot added the awaiting review label Jun 23, 2022
@miss-islington

miss-islington commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Jun 23, 2022
gh-93976: Remove Enum docstring generation #94188
Merged
@bedevere-bot bedevere-bot added skip news type-bug An unexpected behavior, bug, or error labels Jun 23, 2022
@miss-islington

miss-islington commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

@dignissimus and @ethanfurman: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ethanfurman
ethanfurman approved these changes Jun 23, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 23, 2022
@miss-islington

miss-islington commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

@dignissimus and @ethanfurman: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ethanfurman ethanfurman changed the title [3.11] [Enum] Remove automatic docstring generation (GH-94188) [3.11] gh-93976: [Enum] Remove automatic docstring generation (GH-94188) Jun 23, 2022
@miss-islington

miss-islington commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit fbf3145 into python:3.11 Jun 23, 2022
@miss-islington

miss-islington commented Jun 23, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: Pull Request is not mergeable.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 23, 2022
@miss-islington
miss-islington deleted the backport-28a2ccf-3.11 branch June 23, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @ethanfurman @bedevere-bot @dignissimus
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.