GeezerVison is showing github.com — [3.11] gh-84461: Fix ctypes and test_ctypes on Emscripten (GH-94142) by miss-islington · Pull Request #94211 · python/cpython
Conversation
miss-islington
commented
Jun 24, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
- c_longlong and c_longdouble need experimental WASM bigint.
- Skip tests that need threading
- Define
CTYPES_MAX_ARGCOUNT for Emscripten. libffi-emscripten 2022-06-23 supports up to 1000 args.
(cherry picked from commit 8625802)
Co-authored-by: Christian Heimes [email protected]
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
)
- c_longlong and c_longdouble need experimental WASM bigint.
- Skip tests that need threading
- Define ``CTYPES_MAX_ARGCOUNT`` for Emscripten. libffi-emscripten 2022-06-23 supports up to 1000 args.
(cherry picked from commit 8625802)
Co-authored-by: Christian Heimes <[email protected]>
|
Status check is done, and it's a success ✅ .
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Status check is done, and it's a success ✅ .
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
1 more reviewer
tiran
tiran approved these changes
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.