GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94172: urllib.request avoids deprecated key_file/cert_file by vstinner · Pull Request #94232 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The urllib.request module no longer uses the deprecated key_file and
cert_file parameter of the http.client module.

  • Issue: Remove deprecated keyfile, certfile and check_hostname parameters, in favor of context #94172

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-94172: urllib.request avoids deprecated key_file/cert_file
0584d99 
The urllib.request module no longer uses the deprecated key_file and
cert_file parameter of the http.client module.
@vstinner vstinner added the skip news label Jun 24, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jun 24, 2022
@vstinner vstinner mentioned this pull request Jun 24, 2022
gh-94172: Remove keyfile, certfile and check_hostname parameters #94173
Merged
@vstinner
vstinner marked this pull request as ready for review June 24, 2022 16:34
vstinner
vstinner commented Jun 24, 2022
View reviewed changes
Comment thread Lib/urllib/request.py
# cert and key file means the user wants to authenticate.
# enable TLS 1.3 PHA implicitly even for custom contexts.
if context.post_handshake_auth is not None:
context.post_handshake_auth = True

@vstinner vstinner Jun 24, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This post_handshake_auth code is already in _create_https_context(), but I copied Python 3.11 code which also checks again post_handshake_auth after calling load_cert_chain().

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner merged commit 37118fa into python:main Jun 26, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 26, 2022
@vstinner
vstinner deleted the urllib_key_file branch June 26, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.