GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-94245: Fix pickling and copying of typing.Tuple[()] by serhiy-storchaka · Pull Request #94260 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jun 25, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It is an alternate PR, which only fixes pickling and copying typing.Tuple[()], without affecting its __args__.

  • Issue: pickling fails for typing.Tuple[()] #94245

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-94245: Fix pickling and copying of typing.Tuple[()]
8d1afcf
@serhiy-storchaka serhiy-storchaka added the type-bug An unexpected behavior, bug, or error label Jun 25, 2022
@serhiy-storchaka
serhiy-storchaka requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners June 25, 2022 10:36
@bedevere-bot bedevere-bot added the awaiting core review label Jun 25, 2022
@serhiy-storchaka serhiy-storchaka mentioned this pull request Jun 25, 2022
pickling fails for typing.Tuple[()] #94245
Closed
@JelleZijlstra JelleZijlstra changed the title gh-94245: Fix pickling and copying of typing.Tuple[()] [3.10] gh-94245: Fix pickling and copying of typing.Tuple[()] Jun 25, 2022
JelleZijlstra
JelleZijlstra approved these changes Jun 25, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd prefer this over backporting your other change, since it's less disruptive.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 25, 2022
Fidget-Spinner
Fidget-Spinner approved these changes Jun 25, 2022
View reviewed changes
gvanrossum
gvanrossum approved these changes Jun 25, 2022
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit 75dda3b into python:3.10 Jun 25, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 25, 2022
@serhiy-storchaka
serhiy-storchaka deleted the typing-empty-tuple-pickle-copy-3.10 branch June 25, 2022 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @JelleZijlstra @gvanrossum @Fidget-Spinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.