GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93370: Drop deprecated sqlite3.version from pythoninfo.py by erlend-aasland · Pull Request #94277 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Jun 25, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Resolves gh-93370

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-93370: Catch sqlite3.version deprecation warning in pythonin…
df497a9 
…fo.py
@bedevere-bot bedevere-bot added the awaiting core review label Jun 25, 2022
@erlend-aasland erlend-aasland added the skip news label Jun 25, 2022
@erlend-aasland
erlend-aasland requested a review from JelleZijlstra June 25, 2022 22:13
@serhiy-storchaka

serhiy-storchaka commented Jun 26, 2022

Copy link
Copy Markdown
Member

I think there is no need to output sqlite3.version.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Jun 26, 2022

Copy link
Copy Markdown
Contributor Author

I think there is no need to output sqlite3.version.

+1
Even better!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Address review: Drop sqlite3.version
b325a0c
@erlend-aasland erlend-aasland changed the title gh-93370: Catch sqlite3.version deprecation warning in pythoninfo.py gh-93370: Drop deprecated sqlite3.version from pythoninfo.py Jun 26, 2022
serhiy-storchaka
serhiy-storchaka approved these changes Jun 26, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 26, 2022
@erlend-aasland
erlend-aasland merged commit 27934be into python:main Jun 26, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 26, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-pythoninfo branch June 26, 2022 10:10
@erlend-aasland

erlend-aasland commented Jun 26, 2022

Copy link
Copy Markdown
Contributor Author

Thanks for the review, Serhiy.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Deprecate sqlite3.version and sqlite3.version_info #93370
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate sqlite3.version and sqlite3.version_info

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.